Changeset 3677


Ignore:
Timestamp:
Jun 21, 2013, 3:00:33 AM (17 months ago)
Author:
quozl
Message:

OLPC - when testing /usb/hub in diag mode, fail the test if the device is removed during the probe. Reported by Chia-Hsiu. Also fix stack comments in other selftest methods.

Files:
6 edited

Legend:

Unmodified
Added
Removed
  • cpu/arm/olpc/1.75/leds.fth

    r3198 r3677  
    2727: hdd-led-toggle  ( -- )  led-storage-gpio# gpio-pin@  if  hdd-led-off  else  hdd-led-on  then  ; 
    2828 
    29 : selftest  ( -- ) 
     29: selftest  ( -- error? ) 
    3030   ." Flashing LEDs" cr 
    3131 
     
    3939   ols-assy-mode-off 
    4040 
    41    confirm-selftest? 
     41   confirm-selftest?  ( error? ) 
    4242; 
    4343 
  • cpu/arm/olpc/3.0/leds.fth

    r3049 r3677  
    88: close  ( -- )  ; 
    99 
    10 : selftest  ( -- ) 
     10: selftest  ( -- error? ) 
    1111   ." Flashing LEDs" cr 
    1212 
  • cpu/x86/pc/olpc/via/leds.fth

    r2488 r3677  
    77: open  ( -- okay? )  true  ; 
    88: close  ( -- )  ; 
    9 : selftest  ( -- ) 
     9: selftest  ( -- error? ) 
    1010   ." Flashing LEDs" cr 
    1111   " /wlan" test-dev  " /wlan" test-dev  \ Twice for longer flashing 
  • dev/usb2/device/hub/hub.fth

    r2233 r3677  
    5454   then 
    5555; 
    56 : selftest  ( -- ) 
     56: selftest  ( -- error? ) 
    5757   ['] hub-id catch 0=  if 
    58       hub-selftest-xt execute 
     58      hub-selftest-xt catch if true then 
     59   else 
     60      true 
    5961   then 
    6062; 
  • dev/usb2/hcd/device.fth

    r3444 r3677  
    387387: .usb-device  ( port -- ) 
    388388   find-port-node  if 
    389       ." Can't find device node for USB port!" cr 
     389      ." Can't find device node for USB port!" cr abort 
    390390   else                                      ( phandle ) 
    391391      dup " device_type" .phandle-property   ( phandle ) 
  • dev/usb2/hcd/probehub.fth

    r3444 r3677  
    244244 
    245245   \ Maybe need to reset the entire hub here 
    246    false                                        ( false ) 
     246   false                                                ( false ) 
    247247; 
    248248: hub-selftest-xt  ( -- xt )  ['] hub-selftest  ; 
Note: See TracChangeset for help on using the changeset viewer.