Changeset 2996

Timestamp:

Jun 1, 2012 8:33:29 PM (12 months ago)

Author:

wmb

Message:

FCode tokenizer - removed the macro versions of */ and */mod, which do not work correctly (the intermediate result can overflow). If you need to use these functions in an FCode driver, use um* and um/mod to perform the calculations.

File:

• ofw/tokenizer/crosslis.fth (modified) (1 diff)

ofw/tokenizer/crosslis.fth

@@ -141 +141 @@
 : 2-    2 - ;
 : <<a   << ;
-: */mod  >r * r> /mod ;
-: */     >r * r> /    ;
+\ These are not correct because the intermediate overflows.
+\ If you need these functions, write them explicitly using um* and um/mod
+\ : */mod  >r * r> /mod ;
+\ : */     >r * r> /    ;
 : xu>l        ( ux -- ul ) drop   ;                    \       64 -> 32
 : lu>x        ( ul -- ux ) 0      ;                    \ 32 -> 64