Changeset 2795

Timestamp:

Dec 31, 2011 11:25:58 PM (18 months ago)

Author:

wmb

Message:

OLPC trac #11349 - The generic "$delete1" file command was leaving a directory ihandle open in the case where the file could not be deleted, leading to a delayed action bug that could cause write data not to be flushed from the disk buffer.

File:

• ofw/core/filecmds.fth (modified) (1 diff)

ofw/core/filecmds.fth

@@ -296 +296 @@
 : $delete1  ( path$ -- )
    open-directory ?dup 0= abort" Can't open directory"      ( name$ dir-ih )
-   >r  " $delete!" r@ $call-method  abort" Can't delete file"  ( r: dir-ih ) 
-   r> close-dev   
+   >r  " $delete!" r@ $call-method  ( error?  r: dir-ih ) 
+   r> close-dev                     ( error? )
+   abort" Can't delete file"  
 ;
 ' $delete1 to _ofdelete