Changeset 579 for trunk/82802ab.c

Timestamp:

Jun 5, 2009 8:32:07 PM (4 years ago)

Author:

hailfinger

Message:

Sometimes we want to read/write more than 4 bytes of chip content at
once.
Add chip_{read,write}n to the external flasher infrastructure which
read/write n bytes at once.

Fix a few places where the code used memcpy/memcmp although that is
strictly impossible with external flashers.
Place a FIXME in the layout.c code because usage is not totally clear
and needs to be fixed to support external flashers.

As a nice side benefit, we get a noticeable speedup for builtin flash
reading which is now a memcpy() of the full flash area instead of a
series of single-byte reads.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@…>
Acked-by: Urja Rannikko <urjaman@…>
Acked-by: Uwe Hermann <uwe@…>

File:

• trunk/82802ab.c (modified) (4 diffs)

trunk/82802ab.c

@@ -28 +28 @@
 
 #include <string.h>
+#include <stdlib.h>
 #include "flash.h"
 
@@ -173 +174 @@
         int page_size = flash->page_size;
         chipaddr bios = flash->virtual_memory;
-
+        uint8_t *tmpbuf = malloc(page_size);
+
+        if (!tmpbuf) {
+                printf("Could not allocate memory!\n");
+                exit(1);
+        }
         printf("Programming page: \n");
         for (i = 0; i < total_size / page_size; i++) {
@@ -187 +193 @@
                  * sudden power off situations
                  */
-                if (!memcmp((void *)(buf + i * page_size),
-                            (void *)(bios + i * page_size), page_size)) {
+                chip_readn(tmpbuf, bios + i * page_size, page_size);
+                if (!memcmp((void *)(buf + i * page_size), tmpbuf, page_size)) {
                         printf("SKIPPED\n");
                         continue;
@@ -200 +206 @@
         printf("\n");
         protect_jedec(bios);
+        free(tmpbuf);
 
         return 0;