Changeset 519 for trunk/w29ee011.c

Timestamp:

May 16, 2009 11:22:56 PM (4 years ago)

Author:

hailfinger

Message:

Use chipaddr instead of volatile uint8_t * because when we access
chips in external flashers, they are not accessed via pointers at all.

Benefits:
This allows us to differentiate between volatile machine memory accesses
and flash chip accesses.
It also enforces usage of chip_{read,write}[bwl] to access flash chips,
so nobody will unintentionally use pointers to access chips anymore.
Some unneeded casts are removed as well.
Grepping for chip operations and machine memory operations doesn't yield
any false positives anymore.

Compile tested on 32 bit and 64 bit Linux.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@…>
Acked-by: Uwe Hermann <uwe@…>

File:

• trunk/w29ee011.c (modified) (1 diff)

trunk/w29ee011.c

@@ -24 +24 @@
 int probe_w29ee011(struct flashchip *flash)
 {
-        volatile uint8_t *bios = flash->virtual_memory;
+        chipaddr bios = flash->virtual_memory;
         uint8_t id1, id2;
         extern char *chip_to_probe;