Changeset 1475 for trunk/flashrom.c

Timestamp:

Dec 20, 2011 1:19:29 AM (17 months ago)

Author:

hailfinger

Message:

Have all programmer init functions register bus masters/programmers

All programmer types (Parallel, SPI, Opaque) now register themselves
into a generic programmer list and probing is now programmer-centric
instead of chip-centric.
Registering multiple SPI/... masters at the same time is now possible
without any problems. Handling multiple flash chips is still unchanged,
but now we have the infrastructure to deal with "dual BIOS" and "one
flash behind southbridge and one flash behind EC" sanely.

A nice side effect is that this patch kills quite a few global variables
and improves the situation for libflashrom.

Hint for developers:
struct {spi,par,opaque}_programmer now have a void *data pointer to
store any additional programmer-specific data, e.g. hardware
configuration info.

Note:
flashrom -f -c FOO -r forced_read.bin
does not work anymore. We have to find an architecturally clean way to
solve this.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@…>
Acked-by: Michael Karcher <flashrom@…>

File:

• trunk/flashrom.c (modified) (8 diffs)

trunk/flashrom.c

@@ -47 +47 @@
 static char *programmer_param = NULL;
 
-/* Supported buses for the current programmer. */
-enum chipbustype buses_supported;
-
 /*
  * Programmers supporting multiple buses can have differing size limits on
@@ -315 +312 @@
                 .spi            = 0xffffffff,
         };
-        buses_supported = BUS_NONE;
         /* Default to top aligned flash at 4 GB. */
         flashbase = 0;
@@ -362 +358 @@
 void chip_writeb(const struct flashctx *flash, uint8_t val, chipaddr addr)
 {
-        par_programmer->chip_writeb(flash, val, addr);
+        flash->pgm->par.chip_writeb(flash, val, addr);
 }
 
 void chip_writew(const struct flashctx *flash, uint16_t val, chipaddr addr)
 {
-        par_programmer->chip_writew(flash, val, addr);
+        flash->pgm->par.chip_writew(flash, val, addr);
 }
 
 void chip_writel(const struct flashctx *flash, uint32_t val, chipaddr addr)
 {
-        par_programmer->chip_writel(flash, val, addr);
+        flash->pgm->par.chip_writel(flash, val, addr);
 }
 
@@ -378 +374 @@
                  size_t len)
 {
-        par_programmer->chip_writen(flash, buf, addr, len);
+        flash->pgm->par.chip_writen(flash, buf, addr, len);
 }
 
 uint8_t chip_readb(const struct flashctx *flash, const chipaddr addr)
 {
-        return par_programmer->chip_readb(flash, addr);
+        return flash->pgm->par.chip_readb(flash, addr);
 }
 
 uint16_t chip_readw(const struct flashctx *flash, const chipaddr addr)
 {
-        return par_programmer->chip_readw(flash, addr);
+        return flash->pgm->par.chip_readw(flash, addr);
 }
 
 uint32_t chip_readl(const struct flashctx *flash, const chipaddr addr)
 {
-        return par_programmer->chip_readl(flash, addr);
+        return flash->pgm->par.chip_readl(flash, addr);
 }
 
@@ -399 +395 @@
                 size_t len)
 {
-        par_programmer->chip_readn(flash, buf, addr, len);
+        flash->pgm->par.chip_readn(flash, buf, addr, len);
 }
 
@@ -943 +939 @@
 }
 
-int probe_flash(int startchip, struct flashctx *fill_flash, int force)
+int probe_flash(struct registered_programmer *pgm, int startchip,
+                struct flashctx *fill_flash, int force)
 {
         const struct flashchip *flash;
@@ -955 +952 @@
                 if (chip_to_probe && strcmp(flash->name, chip_to_probe) != 0)
                         continue;
-                buses_common = buses_supported & flash->bustype;
-                if (!buses_common) {
-                        msg_gspew("Probing for %s %s, %d kB: skipped. ",
-                                 flash->vendor, flash->name, flash->total_size);
-                        tmp = flashbuses_to_text(buses_supported);
-                        msg_gspew("Host bus type %s ", tmp);
-                        free(tmp);
-                        tmp = flashbuses_to_text(flash->bustype);
-                        msg_gspew("and chip bus type %s are incompatible.",
-                                  tmp);
-                        free(tmp);
-                        msg_gspew("\n");
+                buses_common = pgm->buses_supported & flash->bustype;
+                if (!buses_common)
                         continue;
-                }
                 msg_gdbg("Probing for %s %s, %d kB: ",
                              flash->vendor, flash->name, flash->total_size);
@@ -982 +968 @@
                 /* Start filling in the dynamic data. */
                 memcpy(fill_flash, flash, sizeof(struct flashchip));
+                fill_flash->pgm = pgm;
 
                 base = flashbase ? flashbase : (0xffffffff - size + 1);