Changeset 1464 for trunk


Ignore:
Timestamp:
Nov 13, 2011, 3:17:10 PM (4 years ago)
Author:
stefanct
Message:

ichspi: fix ich_init_opcodes() calls in ich_init_spi()

By calling it early ichspi_lock was not set up correctly in accordance
with the corresponding register, hence ich_init_opcodes() was always
trying to programming the opcodes instead of reading them in from the
opmenu in case of a locked down configuration.

Thanks to Jonathan A. Kollasch for reporting this bug.

Signed-off-by: Stefan Tauner <stefan.tauner@…>
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@…>

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/ichspi.c

    r1463 r1464  
    15631563        ich_spibar = rcrb + spibar_offset;
    15641564
    1565         ich_init_opcodes();
    1566 
    15671565        switch (ich_generation) {
    15681566        case CHIPSET_ICH7:
     
    16021600                        ichspi_lock = 1;
    16031601                }
     1602                ich_init_opcodes();
    16041603                ich_set_bbar(0);
    16051604                register_spi_programmer(&spi_programmer_ich7);
     
    16441643                                  "effect. Please note that Protected\n"
    16451644                                  "Range (PR) restrictions still apply.\n");
     1645                ich_init_opcodes();
    16461646
    16471647                if (desc_valid) {
Note: See TracChangeset for help on using the changeset viewer.