Changeset 1356

Timestamp:

Jun 26, 2011 8:28:58 PM (2 years ago)

Author:

stefanct

Message:

make Makefile's test programs safe(r)

we don't use -W or similarly strict compiler checks (yet), but
enabling its use is a good thing. if you add -W to the cflags
without this patch, detection of the compiler will fail with gcc 4.4
for example, because compiling of the test program will fail due to
a warning of unused arguments and -Werror. similarly the other
checks involving compiling test programs would fail.

Signed-off-by: Stefan Tauner <stefan.tauner@…>
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@…>

File:

• trunk/Makefile (modified) (5 diffs)

trunk/Makefile

@@ -414 +414 @@
         @printf "Checking for a C compiler... "
         @$(shell ( echo "int main(int argc, char **argv)"; \
-                   echo "{ return 0; }"; ) > .test.c )
+                   echo "{ (void) argc; (void) argv; return 0; }"; ) > .test.c )
         @$(CC) $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) .test.c -o .test$(EXEC_SUFFIX) >/dev/null &&    \
                 echo "found." || ( echo "not found."; \
@@ -428 +428 @@
                    echo "struct pci_access *pacc;";        \
                    echo "int main(int argc, char **argv)"; \
-                   echo "{ pacc = pci_alloc(); return 0; }"; ) > .test.c )
+                   echo "{ (void) argc; (void) argv; pacc = pci_alloc(); return 0; }"; ) > .test.c )
         @$(CC) -c $(CPPFLAGS) $(CFLAGS) .test.c -o .test.o >/dev/null 2>&1 &&           \
                 echo "found." || ( echo "not found."; echo;                     \
@@ -470 +470 @@
                    echo "struct ftdi_context *ftdic = NULL;";      \
                    echo "int main(int argc, char **argv)"; \
-                   echo "{ return ftdi_init(ftdic); }"; ) > .featuretest.c )
+                   echo "{ (void) argc; (void) argv; return ftdi_init(ftdic); }"; ) > .featuretest.c )
         @$(CC) $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) .featuretest.c -o .featuretest$(EXEC_SUFFIX) $(FTDILIBS) $(LIBS) >/dev/null 2>&1 &&     \
                 ( echo "found."; echo "FTDISUPPORT := yes" >> .features.tmp ) ||        \
@@ -478 +478 @@
                    echo "struct utsname osinfo;";          \
                    echo "int main(int argc, char **argv)"; \
-                   echo "{ uname (&osinfo); return 0; }"; ) > .featuretest.c )
+                   echo "{ (void) argc; (void) argv; uname (&osinfo); return 0; }"; ) > .featuretest.c )
         @$(CC) $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) .featuretest.c -o .featuretest$(EXEC_SUFFIX) >/dev/null 2>&1 && \
                 ( echo "found."; echo "UTSNAME := yes" >> .features.tmp ) ||    \
@@ -491 +491 @@
                    echo "struct utsname osinfo;";          \
                    echo "int main(int argc, char **argv)"; \
-                   echo "{ uname (&osinfo); return 0; }"; ) > .featuretest.c )
+                   echo "{ (void) argc; (void) argv; uname (&osinfo); return 0; }"; ) > .featuretest.c )
         @$(CC) $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) .featuretest.c -o .featuretest$(EXEC_SUFFIX) >/dev/null 2>&1 && \
                 ( echo "found."; echo "UTSNAME := yes" >> .features.tmp ) ||    \