Modify

Opened 6 years ago

Last modified 6 years ago

#14 new defect

'poweroff' doesn't work

Reported by: hawke@… Owned by: somebody
Priority: minor Milestone:
Component: FILO Version:
Keywords: Cc:
Dependencies: Patch Status: there is no patch

Description

the 'poweroff' command doesn't seem to work, and just hangs filo. It would be nice for it to print an error message and return to the prompt rather than hanging.

Attachments (0)

Change History (2)

comment:1 Changed 6 years ago by oxygene

As far as I know, power-off works by writing to an IO-port and then wait for the system to shut down.

The only alternative would be to write the message ("It's safe to shut down your computer"), then do the power-off routine, so that the message is visible in case the system does not shut down.

Returning to the prompt would require the system to return some kind of error condition, so that filo knows that the system does not intend to cease operation.

Of course, fixing power-off itself is part of the solution, too... (see drivers/intel.c, platform_poweroff)

comment:2 Changed 6 years ago by hawke@…

Can't it be assumed that any time we're at the filo prompt, it's safe to shut down? I would certainly hope so. The only time it might be unsafe is while nvram is being written, and that's 1. a very small window, 2. very rare, and 3. not happening while at a prompt. I think it might be better to print "Attempting to power down...", run the poweroff routine, and then return to the commandline.

Add Comment

Modify Ticket

Action
as new .
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.