Modify

Opened 8 years ago

Closed 7 years ago

#80 closed enhancement (fixed)

serial console in grub2 works

Reported by: oxygene Owned by: oxygene
Priority: major Milestone: Port GRUB2 to coreboot
Component: grub2 Keywords:
Cc: Dependencies:
Patch Status: patch needs review

Description

grub2 should be capable of using the serial console, just like lbv3 is

Attachments (1)

patch-20070714-1-legacy-serial-table (777 bytes) - added by oxygene 8 years ago.
hack so grub2 finds the serial port table at the expected place.

Download all attachments as: .zip

Change History (9)

Changed 8 years ago by oxygene

hack so grub2 finds the serial port table at the expected place.

comment:1 Changed 8 years ago by oxygene

  • Patch Status changed from there is no patch to patch needs work
  • Status changed from new to assigned

The patch puts the serial port's I/O port at 0x400, where grub2 looks for it. That probably makes it "legacy support".

Needs proper discussion if such legacy tables should be written by linuxbios and if so, where such code should end up.

comment:2 Changed 8 years ago by oxygene

  • Patch Status changed from patch needs work to patch needs review
  • Resolution set to fixed
  • Status changed from assigned to closed

comment:3 Changed 8 years ago by rmh@…

Not necessary. We'll fix this by hardcoding 0x3f8 / 0x2f8 like LinuxBIOS is doing. Thanks for the pointer.

comment:4 Changed 8 years ago by stuge

Is that really good enough? Isn't the console serial port in the LinuxBIOS table? If not, it should be. I guess it can and will change, especially for v3.

This touches on the previous discussion about LB->payload interface specs.

As long as GRUB2 has abstraction for LB I'm happy with whatever for now, but assuming that LB will always behave/provide like legacy BIOS is certainly not the way I would like it to work.

Is this really closed?

comment:5 Changed 8 years ago by stepan

  • Resolution fixed deleted
  • Status changed from closed to reopened

Peter is right here. In fact, the serial port is by no means hard coded in LinuxBIOS. Instead it is a CONFIG_ variable. This should indeed be exported via the LinuxBIOS table. This should be easy to do in v2 and v3.

comment:6 Changed 8 years ago by rmh@…

I was assuming that LinuxBIOS table would export a port number rather than an IO address. That sounds more portable to me.

comment:7 Changed 7 years ago by uwe

  • Component changed from code to grub2
  • version v3 deleted

comment:8 Changed 7 years ago by stepan

  • Resolution set to fixed
  • Status changed from reopened to closed

Add Comment

Modify Ticket

Action
as closed The owner will remain oxygene.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.