#69 closed defect (fixed)
Fix mptable util so the output will compile
| Reported by: | Jon Dufresne <jon.dufresne@…> | Owned by: | somebody |
|---|---|---|---|
| Priority: | major | Milestone: | |
| Component: | coreboot | Keywords: | |
| Cc: | Dependencies: | ||
| Patch Status: | patch has been committed |
Description
I'm guessing the mptable util is using deprecated functions which is why the output it gave me did not compile in my environment. I used tyan/s2735/mptable.c as a guide for what the correct functions and headers should be.
Attachments (3)
Change History (6)
Changed 6 years ago by Jon Dufresne <jon.dufresne@…>
Changed 6 years ago by Jon Dufresne <jon.dufresne@…>
there was a typo in the first patch, this one will really fix it.
Changed 6 years ago by Jon Dufresne <jon.dufresne@…>
I added support for MP_IRQ_*_DEFAULT instead of "conforms", which is unidentified
comment:1 Changed 5 years ago by cozzie
The current mptable output doesn't compile, and with this patch, it does. That's not to say that the output is perfect, but it's one step closer ;) Unless there's some reason not to fix this:
Acked-by: Corey Osgood <corey dot osgood at gmail dot com>
I'll let someone else do the commit, just in case there's some reason not to do this, but I can't think of any. Thanks for the patches Jon, sorry they've sat here in limbo for so long.
comment:2 Changed 5 years ago by cozzie
- Patch Status changed from patch needs review to patch has been committed
- Resolution set to fixed
- Status changed from new to closed
comment:3 Changed 5 years ago by anonymous
Signed-off-by: Jon Dufresne <jon.dufresne@…>
patch to fix wrong headers and function names