Modify

Opened 9 years ago

Closed 8 years ago

Last modified 7 years ago

#69 closed defect (fixed)

Fix mptable util so the output will compile

Reported by: Jon Dufresne <jon.dufresne@…> Owned by: somebody
Priority: major Milestone:
Component: coreboot Keywords:
Cc: Dependencies:
Patch Status: patch has been committed

Description

I'm guessing the mptable util is using deprecated functions which is why the output it gave me did not compile in my environment. I used tyan/s2735/mptable.c as a guide for what the correct functions and headers should be.

Attachments (3)

mptable.patch (2.5 KB) - added by Jon Dufresne <jon.dufresne@…> 9 years ago.
patch to fix wrong headers and function names
mptable.2.patch (2.5 KB) - added by Jon Dufresne <jon.dufresne@…> 9 years ago.
there was a typo in the first patch, this one will really fix it.
mptable.3.patch (2.9 KB) - added by Jon Dufresne <jon.dufresne@…> 9 years ago.
I added support for MP_IRQ_*_DEFAULT instead of "conforms", which is unidentified

Download all attachments as: .zip

Change History (6)

Changed 9 years ago by Jon Dufresne <jon.dufresne@…>

patch to fix wrong headers and function names

Changed 9 years ago by Jon Dufresne <jon.dufresne@…>

there was a typo in the first patch, this one will really fix it.

Changed 9 years ago by Jon Dufresne <jon.dufresne@…>

I added support for MP_IRQ_*_DEFAULT instead of "conforms", which is unidentified

comment:1 Changed 8 years ago by cozzie

The current mptable output doesn't compile, and with this patch, it does. That's not to say that the output is perfect, but it's one step closer ;) Unless there's some reason not to fix this:

Acked-by: Corey Osgood <corey dot osgood at gmail dot com>

I'll let someone else do the commit, just in case there's some reason not to do this, but I can't think of any. Thanks for the patches Jon, sorry they've sat here in limbo for so long.

comment:2 Changed 8 years ago by cozzie

  • Patch Status changed from patch needs review to patch has been committed
  • Resolution set to fixed
  • Status changed from new to closed

comment:3 Changed 7 years ago by anonymous

Signed-off-by: Jon Dufresne <jon.dufresne@…>

Add Comment

Modify Ticket

Action
as closed The owner will remain somebody.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.