Ticket #65 (new enhancement)

Opened 2 years ago

Last modified 9 months ago

Unify SuperIO code?

Reported by: stepan Owned by: uwe
Priority: major Milestone: Cosmetic fixes
Component: coreboot Version:
Keywords: Cc:
Dependencies: Patch Status: there is no patch

Description

One thing I've been noticing in the current superio implementations: A lot of differences come from having the part names used in variable and macro names.

   #define FDC37M60X_CONFIG_REG_CC 0x02

Maybe we should change that to some unique names

   #define SUPERIO_CONFIG_REG_CC 0x02
  • Those names are usually file local only, so name clashes wont be a problem
  • They are the same for most (all?) SuperIOs?

Doing so (maybe with function names as well?) would unify the superio interface, or at least make diffing the code of different devices a bit easier..

Attachments

Change History

Changed 16 months ago by uwe

Yes, the Super I/O code should definately be unified. Ideally one "driver" per Super I/O vendor should handle all the various chips of that vendor.

An example of how this can work is the 'smscsuperio' driver in v2, which should support almost all recent SMSC Super I/O chips. At least for v3 we should only accept this kind of generalized Super I/O drivers in the repository.

Changed 9 months ago by uwe

  • priority changed from minor to major
  • version v2 deleted

Changed 9 months ago by stepan

  • owner changed from somebody to uwe

Add/Change #65 (Unify SuperIO code?)

Author



Action
as new
 
Note: See TracTickets for help on using tickets.