Modify ↓

Opened 7 years ago

Closed 3 years ago

#45 closed enhancement (worksforme)

Enforce consistent coding style

Reported by: uwe Owned by: somebody
Priority: minor Milestone: Cosmetic fixes
Component: coreboot Keywords:
Cc: Dependencies:
Patch Status: there is no patch

Description

We should have a common coding style for all our code (documented in the development guidelines). This is most probably the Linux kernel coding style, as has been agreed by most developers on the LinuxBIOS Symposium 2006.

As a help to achieve this, one can use the 'indent' tool with the following options:

indent -npro -kr -i8 -ts8 -sob -l80 -ss -ncs

Note: The tool should not be completely trusted, it will produce wrong or broken output in certain situations, so manual post-processing might be needed sometimes.

Attachments (0)

Change History (4)

comment:1 Changed 6 years ago by uwe

  • Priority changed from major to blocker
  • version changed from v2 to v3

Probably too much hassle and work for v2, but we definately should enforce this for v3.

comment:2 Changed 4 years ago by stepan

  • Priority changed from blocker to minor

comment:3 Changed 4 years ago by stepan

cosmetics are not blockers.

comment:4 Changed 3 years ago by stepan

  • Resolution set to worksforme
  • Status changed from new to closed

The suggestion has been included in the general Developer's Guidelines for coreboot and as such are established as a de facto standard.

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.