Modify ↓

Opened 4 years ago

Closed 4 years ago

#138 closed defect (fixed)

Flashrom cannot read/verify (-rv) from v2-R3923

Reported by: bothlyn@… Owned by: somebody
Priority: minor Milestone: flashrom v1.0
Component: flashrom (please use trac on flashrom.org) Keywords:
Cc: Dependencies:
Patch Status: patch needs review

Description

flashrom 0.9.0 R545 cannot process -rv (Verification always fails)

This appears to be due to read_flash being moved and parameters being changed in v2-R3923

This means that uint8_t *buf, declared in main, is empty when verify_flash is called.

flashrom -r <filename>

followed by

flashrom -v <filename>

Still works.

Attached patch to flashrom.c appears effective against v2-R4294

Attachments (1)

flashrom.c.patch​ (1.5 KB) - added by bothlyn@… 4 years ago.
Flashrom.c patch file (diff -p output)

Download all attachments as: .zip

Change History (2)

Changed 4 years ago by bothlyn@…

Flashrom.c patch file (diff -p output)

comment:1 Changed 4 years ago by hailfinger

  • Resolution set to fixed
  • Status changed from new to closed

Thanks for your patch.

The read/verify combination (to be more precise, any combination of read/verify/erase/write) is forbidden in newer releases, so this should no longer be a problem.

You can still read, then verify in another step.

I'm closing this issue. If you feel your problem is still there, please reopen.

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.