Modify

Opened 7 years ago

Closed 6 years ago

#113 closed enhancement (invalid)

flashrom -c does not accept vendor+chip name, only chip name

Reported by: anonymous Owned by: somebody
Priority: major Milestone: flashrom v1.1
Component: flashrom (please use trac on flashrom.org) Keywords:
Cc: Dependencies:
Patch Status: there is no patch

Description

there is a bug

Attachments (1)

flash.diff (1.3 KB) - added by anonymous 7 years ago.
fix for double detection of the same flash chip under two different names

Download all attachments as: .zip

Change History (7)

comment:1 Changed 7 years ago by anonymous

omg; why is this not tagged as spam. Here is my bugreport that IS posted as spam:

'flashrom does not support a flash chip named ...', but it does

flashrom gives me the above error which is strange; it says it doesn't support the chip; but it is in the list? I assume this could not be caused by not running make install?

# ./flashrom                        
Calibrating delay loop... OK.
No coreboot table found.
Found chipset "Intel ICH7M", enabling flash write... OK.
Found chip "Macronix MX25L8005" (1024 KB) at physical address 0xfff00000.
Found chip "Macronix unknown Macronix SPI chip" (0 KB) at physical address 0xfffff000.
Multiple flash chips were detected: MX25L8005 unknown Macronix SPI chip
Please specify which chip to use with the -c <chipname> option.

# ./flashrom -f -r -c "Macronix MX25L8005"
Calibrating delay loop... OK.
No coreboot table found.
Found chipset "Intel ICH7M", enabling flash write... OK.
No EEPROM/flash device found.
Force read (-f -r -c) requested, forcing chip probe success:
flashrom does not support a flash chip named 'Macronix MX25L8005'.
Run flashrom -L to view the hardware supported in this flashrom version.

# ./flashrom -L|grep 'Macronix MX25L8005'
Macronix MX25L8005

Changed 7 years ago by anonymous

fix for double detection of the same flash chip under two different names

comment:2 Changed 7 years ago by anonymous

Try the attached patch.

comment:3 Changed 7 years ago by hailfinger

  • Component changed from adlo to flashrom
  • Summary changed from problem to flashrom -c does not accept vendor+chip name, only chip name
  • Type changed from defect to enhancement

Very funny. Your patch breaks flashrom for at least a dozen chips.

The chip vendor is not part of the chip name. Simply use

flashrom -c MX25L8005

One could argue that flashrom -c should accept the combination of vendor and chip name as well, not only the chip name.

comment:4 Changed 6 years ago by stepan

  • Milestone set to flashrom v1.1

comment:5 Changed 6 years ago by hailfinger

Is this feature still wanted? If yes, how do we detect whether a user specified chip vendor+name or just chip name?

comment:6 Changed 6 years ago by hailfinger

  • Resolution set to invalid
  • Status changed from new to closed

I'm tempted to declare this as a simple case of RTFM. The duplicate detection has been fixed for months, and the rest is just a matter of actually reading the output from flashrom.

Add Comment

Modify Ticket

Action
as closed The owner will remain somebody.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.