Ticket #112 (closed defect: fixed)

Opened 5 months ago

Last modified 5 months ago

probe_flash calculates base address before final value of size is known

Reported by: alaricx@… Owned by: somebody
Priority: major Milestone:
Component: flashrom Version: v2
Keywords: probe_flash mmap Cc: segher@…
Dependencies: Patch Status: patch has been committed

Description

Found thanks to segher in #coreboot.

In probe_flash(), flash_baseaddr is set before the getpagesize() > size check, thus can be invalid, causing mmap issues.

Attachments

flashrom-size-0-4G-boom.patch (1.2 KB) - added by segher@… 5 months ago.
patch

Change History

Changed 5 months ago by segher@…

patch

Changed 5 months ago by segher

  • cc segher@… added
  • status changed from new to closed
  • patchstatus changed from patch needs review to patch has been committed
  • resolution set to fixed

Add/Change #112 (probe_flash calculates base address before final value of size is known)

Author



Action
as closed
Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.