Opened 5 years ago

Closed 5 years ago

#112 closed defect (fixed)

probe_flash calculates base address before final value of size is known

Reported by: alaricx@… Owned by: somebody
Priority: major Milestone:
Component: flashrom (please use trac on flashrom.org) Keywords: probe_flash mmap
Cc: segher@… Dependencies:
Patch Status: patch has been committed

Description

Found thanks to segher in #coreboot.

In probe_flash(), flash_baseaddr is set before the getpagesize() > size check, thus can be invalid, causing mmap issues.

Attachments (1)

flashrom-size-0-4G-boom.patch​ (1.2 KB) - added by segher@… 5 years ago.
patch

Download all attachments as: .zip

Change History (2)

Changed 5 years ago by segher@…

patch

comment:1 Changed 5 years ago by segher

  • Cc segher@… added
  • Patch Status changed from patch needs review to patch has been committed
  • Resolution set to fixed
  • Status changed from new to closed

Add Comment

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑
 
Note: See TracTickets for help on using tickets.