Modify

Opened 7 years ago

Closed 6 years ago

#109 closed defect (fixed)

flash base autodetection on AMD SC520

Reported by: stepan Owned by: stepan
Priority: major Milestone: flashrom v1.0
Component: flashrom (please use trac on flashrom.org) Keywords:
Cc: Dependencies:
Patch Status: patch has been committed

Description

this code has been sitting on my hard disk for a while. It drops the nasty ifdefs and implements auto detection for AMD SC520 systems, such as the Technologic Systems TS5300.

Attachments (1)

flashrom_sc520.diff (2.7 KB) - added by stepan 7 years ago.
flashrom sc520 autodetection

Download all attachments as: .zip

Change History (5)

Changed 7 years ago by stepan

flashrom sc520 autodetection

comment:1 Changed 7 years ago by stepan

  • Component changed from adlo to flashrom
  • Milestone set to flashrom v1.0
  • version v2 deleted

comment:2 Changed 7 years ago by hailfinger

  • Patch Status changed from patch needs review to patch needs work

Sorry, trac didn't mail the attachment to the list, so I was unaware of it.

If possible, please move all code inside the if (pci_dev_find(0x1022, 0x3000) != NULL) to chipset_enable.c and have it set a global variable is_elan=true and another variable elan_baseaddr. That way, we can keep the main flashrom loop mostly free of chipset/processor dependent stuff. I'm open to variants of the above, though, as long as code is moved to chipset_enable.c.

comment:3 Changed 7 years ago by hailfinger

The new code is very readable and upon moving it to chipset_enable.c, it is

Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@…>

comment:4 Changed 6 years ago by stuge

  • Patch Status changed from patch needs work to patch has been committed
  • Resolution set to fixed
  • Status changed from new to closed

Add Comment

Modify Ticket

Action
as closed The owner will remain stepan.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.