Ticket #109 (new defect)

Opened 3 months ago

Last modified 3 months ago

flash base autodetection on AMD SC520

Reported by: stepan Owned by: stepan
Priority: major Milestone: flashrom v1.0
Component: flashrom Version:
Keywords: Cc:
Dependencies: Patch Status: patch needs work

Description

this code has been sitting on my hard disk for a while. It drops the nasty ifdefs and implements auto detection for AMD SC520 systems, such as the Technologic Systems TS5300.

Attachments

flashrom_sc520.diff (2.7 kB) - added by stepan 3 months ago.
flashrom sc520 autodetection

Change History

Changed 3 months ago by stepan

flashrom sc520 autodetection

Changed 3 months ago by stepan

  • version v2 deleted
  • component changed from adlo to flashrom
  • milestone set to flashrom v1.0

Changed 3 months ago by hailfinger

  • patchstatus changed from patch needs review to patch needs work

Sorry, trac didn't mail the attachment to the list, so I was unaware of it.

If possible, please move all code inside the if (pci_dev_find(0x1022, 0x3000) != NULL) to chipset_enable.c and have it set a global variable is_elan=true and another variable elan_baseaddr. That way, we can keep the main flashrom loop mostly free of chipset/processor dependent stuff. I'm open to variants of the above, though, as long as code is moved to chipset_enable.c.

Changed 3 months ago by hailfinger

The new code is very readable and upon moving it to chipset_enable.c, it is

Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@…>

Add/Change #109 (flash base autodetection on AMD SC520)

Author



Action
as new
 
Note: See TracTickets for help on using tickets.