Ticket #103 (assigned defect)

Opened 3 months ago

Last modified 3 months ago

flashrom: Don't exit() after successful erase

Reported by: stuge Owned by: stuge
Priority: major Milestone: flashrom v1.0
Component: flashrom Version:
Keywords: erase exit Cc:
Dependencies: Patch Status: patch needs review

Description


Attachments

fr.103.erasenoexit.patch (2.0 kB) - added by stuge 3 months ago.

Change History

Changed 3 months ago by stuge

  • owner changed from somebody to stuge

Changed 3 months ago by stuge

  • status changed from new to assigned

Changed 3 months ago by stuge

Changed 3 months ago by stuge

  • patchstatus changed from there is no patch to patch needs review
  • summary changed from flashrom: Don't exit() after successful erase operation to flashrom: Don't exit() after successful erase

Changed 3 months ago by hailfinger

While I do like the patch, I fear the user interface of flashrom is less than optimal in this case.

AFAICS flashrom -Er and flashrom -rE are equivalent, but user expectation is completely different. Can we honor the order of commands or at least place reading before erasing and writing?

The best solution would be making -r and -E mutually exclusive like -r -and -w are.

Add/Change #103 (flashrom: Don't exit() after successful erase)

Author



Action
as assigned
 
Note: See TracTickets for help on using tickets.