Modify

Opened 7 years ago

Closed 6 years ago

#101 closed defect (fixed)

flashrom: Remove pciutils check from Makefile

Reported by: stuge Owned by: stuge
Priority: trivial Milestone: flashrom v1.1
Component: flashrom (please use trac on flashrom.org) Keywords: pciutils libpci build ldflags
Cc: Dependencies:
Patch Status: patch needs work

Description

The check belongs in a configure script or similar, the check also claims that packages can not be found for any build error, which is not good enough. Has confused more than one user already.

Attachments (1)

fr.Makefile.pciutils.patch (1.2 KB) - added by stuge 7 years ago.

Download all attachments as: .zip

Change History (5)

Changed 7 years ago by stuge

comment:1 Changed 7 years ago by stepan

  • Priority changed from major to trivial

How is an external script different from the script that is already there?

Just suggest a script. But you're suggesting to cut bread with a fork here.

comment:2 Changed 7 years ago by stuge

  • Owner changed from somebody to stuge
  • Patch Status changed from patch needs review to patch needs work

Fair enough, will work on patch.

comment:3 Changed 7 years ago by stepan

  • Milestone changed from flashrom v1.0 to flashrom 1.1

Moving this to 1.1

comment:4 Changed 6 years ago by hailfinger

  • Resolution set to fixed
  • Status changed from new to closed

This has been solved by making the libpci check conditional on actually needing libpci (i.e. not for the serial and USB and dummy flashers).

Add Comment

Modify Ticket

Action
as closed The owner will remain stuge.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.