Changeset 5190

Timestamp:

Mar 5, 2010 7:25:19 PM (3 years ago)

Author:

stepan

Message:

i945 mini patch:

• don't skip the reset on S4 violations. Specs ask us to do this so we do it
• hlt on waiting for reset instead of hot looping.

Signed-off-by: Stefan Reinauer <stepan@…>
Acked-by: Stefan Reinauer <stepan@…>

File:

• trunk/src/northbridge/intel/i945/raminit.c (modified) (2 diffs)

trunk/src/northbridge/intel/i945/raminit.c

@@ -237 +237 @@
                 if (reg8 & (1<<2)) {
                         printk_debug("SLP S4# Assertion Width Violation.\n");
-
+                        /* Write back clears bit 2 */
                         pci_write_config8(PCI_DEV(0, 0x1f, 0), 0xa2, reg8);
+                        do_reset = 1;
 
                 }
@@ -258 +259 @@
                         outb(0x00, 0xcf9);
                         outb(0x0e, 0xcf9);
-                        for (;;) ; /* Wait for reset! */
+                        for (;;) asm("hlt"); /* Wait for reset! */
                 }
         }