Show
Ignore:
Timestamp:
09/30/08 17:02:40 (3 months ago)
Author:
uwe
Message:

Coding-style fixes and simplifications for the ASUS A8N-E (trivial).
The only non-cosmetic change is s/A8NE/A8N-E/ for the board name.
This is build-tested by me.

Signed-off-by: Uwe Hermann <uwe@…>
Acked-by: Uwe Hermann <uwe@…>

Files:
1 modified

Legend:

Unmodified
Added
Removed
  • trunk/coreboot-v2/src/mainboard/asus/a8n_e/irq_tables.c

    r3052 r3622  
    2121 * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA 
    2222 */ 
    23  
    24 /* Documentation at: http://www.microsoft.com/hwdev/busbios/PCIIRQ.HTM */ 
    2523 
    2624#include <console/console.h> 
     
    6462unsigned long write_pirq_routing_table(unsigned long addr) 
    6563{ 
    66  
    6764        struct irq_routing_table *pirq; 
    6865        struct irq_info *pirq_info; 
    69         unsigned slot_num; 
    70         uint8_t *v; 
     66        unsigned slot_num, sbdn; 
     67        uint8_t *v, sum = 0; 
     68        int i; 
    7169 
    72         uint8_t sum = 0; 
    73         int i; 
    74         unsigned sbdn; 
    75  
    76         /* get_bus_conf() will find out all bus num and apic that share with  
    77          * mptable.c and mptable.c 
     70        /* get_bus_conf() will find out all bus num and APIC that share with  
     71         * mptable.c and mptable.c. 
    7872         */ 
    7973        get_bus_conf(); 
     
    8478        addr &= ~15; 
    8579 
    86         /* This table must be betweeen 0xf0000 & 0x100000 */ 
     80        /* This table must be betweeen 0xf0000 & 0x100000. */ 
    8781        printk_info("Writing IRQ routing tables to 0x%x...", addr); 
    8882 
    8983        pirq = (void *)(addr); 
    90         v = (uint8_t *) (addr); 
     84        v = (uint8_t *)(addr); 
    9185 
    9286        pirq->signature = PIRQ_SIGNATURE; 
    9387        pirq->version = PIRQ_VERSION; 
    94  
    9588        pirq->rtr_bus = bus_ck804[0]; 
    9689        pirq->rtr_devfn = ((sbdn + 9) << 3) | 0; 
    97  
    9890        pirq->exclusive_irqs = 0x828; 
    99  
    10091        pirq->rtr_vendor = 0x10de; 
    10192        pirq->rtr_device = 0x005c; 
    102  
    10393        pirq->miniport_data = 0; 
    10494 
     
    10898        slot_num = 0; 
    10999 
    110 //Slot1 PCIE 16x  
     100        /* Slot1 PCIE 16x */ 
    111101        write_pirq_info(pirq_info, bus_ck804[1], (0 << 3) | 0, 0x3, 0xdeb8, 0x4, 
    112102                        0xdeb8, 0x1, 0xdeb8, 0x2, 0xdeb8, 4, 0); 
     
    114104        slot_num++; 
    115105 
    116 //Slot2 PCIE 1x 
     106        /* Slot2 PCIE 1x */ 
    117107        write_pirq_info(pirq_info, bus_ck804[2], (0 << 3) | 0, 0x4, 0xdeb8, 0x1, 
    118108                        0xdeb8, 0x2, 0xdeb8, 0x3, 0xdeb8, 5, 0); 
     
    120110        slot_num++; 
    121111 
    122 //Slot3 PCIE 1x 
     112        /* Slot3 PCIE 1x */ 
    123113        write_pirq_info(pirq_info, bus_ck804[3], (0 << 3) | 0, 0x1, 0xdeb8, 0x2, 
    124114                        0xdeb8, 0x3, 0xdeb8, 0x4, 0xdeb8, 6, 0); 
     
    126116        slot_num++; 
    127117 
    128 //Slot4 PCIE 4x  
    129         write_pirq_info(pirq_info, bus_ck804[4], (0x4 << 3) | 0, 
    130                         0x2, 0xdeb8, 0x3, 0xdeb8, 0x4, 0xdeb8, 0x1, 0xdeb8, 
    131                         7, 0); 
     118        /* Slot4 PCIE 4x */ 
     119        write_pirq_info(pirq_info, bus_ck804[4], (0x4 << 3) | 0, 0x2, 
     120                        0xdeb8, 0x3, 0xdeb8, 0x4, 0xdeb8, 0x1, 0xdeb8, 7, 0); 
    132121        pirq_info++; 
    133122        slot_num++; 
    134123 
    135 //Slot5 - 7 PCI 
     124        /* Slot5 - Slot7 PCI */ 
    136125        for (i = 0; i < 3; i++) { 
    137126                write_pirq_info(pirq_info, bus_ck804[5], (0 << (6 + i)) | 0, 
     
    144133        } 
    145134 
    146 //pci bridge 
     135        /* PCI bridge */ 
    147136        write_pirq_info(pirq_info, bus_ck804[0], ((sbdn + 9) << 3) | 0, 0x1, 
    148137                        0xdeb8, 0x2, 0xdeb8, 0x3, 0xdeb8, 0x4, 0xdeb8, 0, 0); 
     
    150139        slot_num++; 
    151140 
    152 //smbus 
     141        /* SMBus */ 
    153142        write_pirq_info(pirq_info, bus_ck804[0], ((sbdn + 1) << 3) | 0, 0x2, 
    154143                        0xdeb8, 0, 0, 0, 0, 0, 0, 0, 0); 
     
    156145        slot_num++; 
    157146 
    158 //usb 
     147        /* USB */ 
    159148        write_pirq_info(pirq_info, bus_ck804[0], ((sbdn + 2) << 3) | 0, 0x1, 
    160149                        0xdeb8, 0x2, 0xdeb8, 0, 0, 0, 0, 0, 0); 
     
    162151        slot_num++; 
    163152 
    164 //audio 
     153        /* Audio */ 
    165154        write_pirq_info(pirq_info, bus_ck804[0], ((sbdn + 4) << 3) | 0, 0x1, 
    166155                        0xdeb8, 0, 0, 0, 0, 0, 0, 0, 0); 
    167156        pirq_info++; 
    168157        slot_num++; 
    169 //sata 
     158 
     159        /* SATA */ 
    170160        write_pirq_info(pirq_info, bus_ck804[0], ((sbdn + 7) << 3) | 0, 0x1, 
    171161                        0xdeb8, 0, 0, 0, 0, 0, 0, 0, 0); 
    172162        pirq_info++; 
    173163        slot_num++; 
    174 //sata 
     164 
     165        /* SATA */ 
    175166        write_pirq_info(pirq_info, bus_ck804[0], ((sbdn + 8) << 3) | 0, 0x1, 
    176167                        0xdeb8, 0, 0, 0, 0, 0, 0, 0, 0); 
    177168        pirq_info++; 
    178169        slot_num++; 
    179 //nic 
     170 
     171        /* NIC */ 
    180172        write_pirq_info(pirq_info, bus_ck804[0], ((sbdn + 0xa) << 3) | 0, 0x1, 
    181173                        0xdeb8, 0, 0, 0, 0, 0, 0, 0, 0); 
     
    184176 
    185177#if 0 
    186 //firewire ?? 
     178        /* Firewire? */ 
    187179        write_pirq_info(pirq_info, bus_ck804_1, (0x5 << 3) | 0, 0x3, 0xdeb8, 0, 
    188180                        0, 0, 0, 0, 0, 0, 0); 
     
    197189 
    198190        sum = pirq->checksum - sum; 
    199  
    200         if (sum != pirq->checksum) { 
     191        if (sum != pirq->checksum) 
    201192                pirq->checksum = sum; 
    202         } 
    203193 
    204194        printk_info("done.\n");