Changeset 3622 for trunk/coreboot-v2/src/mainboard/asus/a8n_e/cache_as_ram_auto.c

Timestamp:

09/30/08 17:02:40 (3 months ago)

Author:

uwe

Message:

Coding-style fixes and simplifications for the ASUS A8N-E (trivial).
The only non-cosmetic change is s/A8NE/A8N-E/ for the board name.
This is build-tested by me.

Signed-off-by: Uwe Hermann <uwe@…>
Acked-by: Uwe Hermann <uwe@…>

Files:

• trunk/coreboot-v2/src/mainboard/asus/a8n_e/cache_as_ram_auto.c (modified) (6 diffs)

trunk/coreboot-v2/src/mainboard/asus/a8n_e/cache_as_ram_auto.c

@@ -77 +77 @@
 static void memreset_setup(void)
 {
-        /* FIXME: Nothing to do? */
+        /* Nothing to do. */
 }
 
 static void memreset(int controllers, const struct mem_controller *ctrl)
 {
-        /* FIXME: Nothing to do? */
+        /* Nothing to do. */
 }
 
 static inline void activate_spd_rom(const struct mem_controller *ctrl)
 {
-        /* FIXME: Nothing to do? */
+        /* Nothing to do. */
 }
 
@@ -124 +124 @@
         /* LPC Positive Decode 0 */
         dword = pci_read_config32(PCI_DEV(0, CK804_DEVN_BASE + 1, 0), 0xa0);
-        /* Serial 0, Serial 1 */
-        dword |= (1 << 0) | (1 << 1);
+        dword |= (1 << 0) | (1 << 1);   /* Serial 0, Serial 1 */
         pci_write_config32(PCI_DEV(0, CK804_DEVN_BASE + 1, 0), 0xa0, dword);
 }
@@ -213 +212 @@
 
         int needs_reset;
-        unsigned bsp_apicid = 0;
-
+        unsigned nodes, bsp_apicid = 0;
         struct mem_controller ctrl[8];
-        unsigned nodes;
-
-        if (bist == 0) {
+
+        if (bist == 0)
                 bsp_apicid = init_cpus(cpu_init_detectedx);
-        }
 
         it8712f_24mhz_clkin();
@@ -238 +234 @@
         wait_all_core0_started();
 #if CONFIG_LOGICAL_CPUS==1
-        // It is said that we should start core1 after all core0 launched
+        /* It is said that we should start core1 after all core0 launched. */
         start_other_cores();
         wait_all_other_cores_started(bsp_apicid);
@@ -244 +240 @@
 
         needs_reset |= ht_setup_chains_x();
-
         needs_reset |= ck804_early_setup_x();
 
@@ -255 +250 @@
 
         nodes = get_nodes();
-        //It's the time to set ctrl now;
+        /* It's the time to set ctrl now. */
         fill_mem_ctrl(nodes, ctrl, spd_addr);