Changeset 3587 for trunk/coreboot-v2/src/southbridge/via/k8t890/k8t890_dram.c

Timestamp:

09/20/08 00:58:59 (4 months ago)

Author:

ruik

Message:

Attached patch fixes at least one issue ;) During the PCI BAR sizing must be the

D1F0 bridge without activated I/O and MEM resources, otherwise it will hang
whole PCI bus.

U-boot is also disabling the IO/MEM decode when sizing the BARs, dont know why
does we not.

Second small change just changes a bit which controls the PSTATECTL logic.

Third change deals with the integrated VGA, which needs to be enabled early,
so the VGA_EN is set along the bridges, and PCI K8 resource maps are set
correctly. Finally the CPU accessible framebuffer is now disabled as it is not
needed.

Signed-off-by: Rudolf Marek <r.marek@…>
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@…>

Files:

• trunk/coreboot-v2/src/southbridge/via/k8t890/k8t890_dram.c (modified) (3 diffs)

trunk/coreboot-v2/src/southbridge/via/k8t890/k8t890_dram.c

@@ -64 +64 @@
         /* The Address Next to the Last Valid DRAM Address */
         pci_write_config16(dev, 0x88, (msr.lo >> 24) | reg);
+
+}
+
+static void dram_enable_k8m890(struct device *dev)
+{
+        dram_enable(dev);
+
+        /* enable VGA, so the bridges gets VGA_EN and resources are set */
+        pci_write_config8(dev, 0xa1, 0x80);
 }
 
@@ -114 +123 @@
         printk_debug("VIA FB proposed base: %llx\n", proposed_base);
 
-        /* enable UMA but no FB */
+        /* Step 1: enable UMA but no FB */
         pci_write_config8(dev, 0xa1, 0x80);
 
-        /* 27:21 goes to 7:1, 0 is enable CPU access */
-        tmp = (proposed_base >> 20) | 0x1;
-        pci_write_config8(dev, 0xa0, tmp);
-
-        /* 31:28 goes to 3:0 */
-        tmp = ((proposed_base >> 28) & 0xf);
-        tmp = ((log2(K8M890_FBSIZEMB) - 2) << 4);
-        tmp |= 0x80;
+        /* Step 2: enough is just the FB size, the CPU accessible address is not needed */
+        tmp = ((log2(K8M890_FBSIZEMB) - 2) << 4) | 0x80;
         pci_write_config8(dev, 0xa1, tmp);
 
@@ -142 +145 @@
         .set_resources          = pci_dev_set_resources,
         .enable_resources       = pci_dev_enable_resources,
-        .enable                 = dram_enable,
+        .enable                 = dram_enable_k8m890,
         .init                   = dram_init_fb,
         .ops_pci                = 0,