Changeset 3437 for trunk

Timestamp:

07/24/08 01:22:59 (2 months ago)

Author:

mjones

Message:

This patch fixes the kernel EBDA mislocation problem. Thank you, Yinghai.

The change in tables.c protects the legacy x86 BIOS data segment
(0x400-0x4ff) from being used for storing coreboot tables. Some
bytes from the segment are used by the kernel and should not be
garbled.

The change in coreboot_table.c is not strictly necessary. It removes
some redundancy and confusion.

Signed-off-by: Roman Kononov <kononov@…>
Acked-by: Marc Jones <marc.jones@…>

Location:

trunk/coreboot-v2/src/arch/i386/boot

Files:

• coreboot_table.c (modified) (2 diffs)
• tables.c (modified) (1 diff)

trunk/coreboot-v2/src/arch/i386/boot/coreboot_table.c

@@ -403 +403 @@
         unsigned long rom_table_start, unsigned long rom_table_end)
 {
-        unsigned long table_size;
         struct lb_header *head;
         struct lb_memory *mem;
@@ -446 +445 @@
 
         /* Record the pirq table, acpi tables, and maybe the mptable */
-        table_size=rom_table_end-rom_table_start;
         lb_add_memory_range(mem, LB_MEM_TABLE, 
-                rom_table_start, table_size<0x10000?0x10000:table_size);
+                rom_table_start, rom_table_end-rom_table_start);
 
         /* Note:

trunk/coreboot-v2/src/arch/i386/boot/tables.c

@@ -73 +73 @@
         /* Don't write anything in the traditional x86 BIOS data segment,
          * for example the linux kernel smp need to use 0x467 to pass reset vector
+         * or use 0x40e/0x413 for EBDA finding...
          */
-        if(new_low_table_end>0x467){
+        if(new_low_table_end>0x400){
                 unsigned mptable_size;
                 unsigned mpc_start;