Changeset 3425 for trunk/coreboot-v2/src/northbridge/amd/amdht/h3ncmn.c

Timestamp:

07/17/08 21:50:37 (4 months ago)

Author:

mjones

Message:

Clean up AMD FAM10 HT variable initialization. The structure init is cleaner, avoid compiler warnings, and matches the AMD example code more closely.

Signed-off-by: Marc Jones <marc.jones@…>

Acked-by: Peter Stuge <peter@…>
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@…>

Files:

• trunk/coreboot-v2/src/northbridge/amd/amdht/h3ncmn.c (modified) (6 diffs)

trunk/coreboot-v2/src/northbridge/amd/amdht/h3ncmn.c

@@ -402 +402 @@
                                 {
                                         /* Pass the node and link on which the generic synch flood event occurred. */
-                                        sHtEventHWHtCrc evt = {sizeof(sHtEventHWHtCrc), node, link, (u8)crc};
+                                        sHtEventHWHtCrc evt;
+                                        evt.eSize = sizeof(sHtEventHWHtCrc);
+                                        evt.node = node;
+                                        evt.link = link;
+                                        evt.laneMask = (uint8)crc;
 
                                         pDat->HtBlock->AMD_CB_EventNotify(HT_EVENT_CLASS_HW_FAULT,
@@ -415 +419 @@
                                 {
                                         /* Pass the node and link on which the generic synch flood event occurred. */
-                                        sHtEventHWSynchFlood evt = {sizeof(sHtEventHWSynchFlood), node, link};
+                                        sHtEventHWSynchFlood evt;
+                                        evt.eSize = sizeof(sHtEventHWSynchFlood);
+                                        evt.node = node;
+                                        evt.link = link;
 
                                         pDat->HtBlock->AMD_CB_EventNotify(HT_EVENT_CLASS_HW_FAULT,
@@ -1113 +1120 @@
         }
         STOP_HERE; /*  This is an error internal condition */
-
-        return 0xFF;    // make the compiler happy.
 }
 
@@ -1144 +1149 @@
         }
         STOP_HERE; /*  This is an internal error condition */
-
-        return 0xFF;    // make the compiler happy.
 }
 
@@ -1469 +1472 @@
                                                 if (pDat->HtBlock->AMD_CB_EventNotify)
                                                 {
-                                                        sHtEventOptRequiredCap evt ={sizeof(sHtEventOptRequiredCap),
-                                                                                pDat->PortList[i].NodeID,
-                                                                                pDat->PortList[i].HostLink,
-                                                                                pDat->PortList[i].HostDepth};
+                                                        sHtEventOptRequiredCap evt;
+                                                        evt.eSize = sizeof(sHtEventOptRequiredCap);
+                                                        evt.node = pDat->PortList[i].NodeID;
+                                                        evt.link = pDat->PortList[i].HostLink;
+                                                        evt.depth = pDat->PortList[i].HostDepth;
 
                                                         pDat->HtBlock->AMD_CB_EventNotify(HT_EVENT_CLASS_WARNING,
@@ -1514 +1518 @@
                                                 if (pDat->HtBlock->AMD_CB_EventNotify)
                                                 {
-                                                        sHtEventOptRequiredCap evt ={sizeof(sHtEventOptRequiredCap),
-                                                                        pDat->PortList[i].NodeID,
-                                                                        pDat->PortList[i].HostLink,
-                                                                        pDat->PortList[i].HostDepth};
+                                                        sHtEventOptRequiredCap evt;
+                                                        evt.eSize = sizeof(sHtEventOptRequiredCap);
+                                                        evt.node = pDat->PortList[i].NodeID;
+                                                        evt.link = pDat->PortList[i].HostLink;
+                                                        evt.depth = pDat->PortList[i].HostDepth;
 
                                                         pDat->HtBlock->AMD_CB_EventNotify(HT_EVENT_CLASS_WARNING,