Changeset 3407 for trunk/util/flashrom/flashrom.c

Timestamp:

07/02/08 19:15:47 (5 months ago)

Author:

stuge

Message:

flashrom: probe_flash() cleanup for better code readability

Signed-off-by: Peter Stuge <peter@…>
Acked-by: Stefan Reinauer <stepan@…>

Files:

• trunk/util/flashrom/flashrom.c (modified) (2 diffs)

trunk/util/flashrom/flashrom.c

@@ -103 +103 @@
 {
         volatile uint8_t *bios;
-        unsigned long flash_baseaddr, size;
-
-        while (flash->name != NULL) {
-                if (chip_to_probe && strcmp(flash->name, chip_to_probe) != 0) {
-                        flash++;
+        unsigned long flash_baseaddr = 0, size;
+
+        for (; flash && flash->name; flash++) {
+                if (chip_to_probe && strcmp(flash->name, chip_to_probe) != 0)
                         continue;
-                }
                 printf_debug("Probing for %s %s, %d KB: ",
                              flash->vendor, flash->name, flash->total_size);
                 if (!flash->probe && !force) {
                         printf_debug("failed! flashrom has no probe function for this flash chip.\n");
-                        flash++;
                         continue;
                 }
@@ -151 +148 @@
                 flash->virtual_memory = bios;
 
-                if (force || flash->probe(flash) == 1) {
-                        printf("Found chip \"%s %s\" (%d KB) at physical address 0x%lx.\n",
-                               flash->vendor, flash->name, flash->total_size,
-                               flash_baseaddr);
-                        return flash;
-                }
+                if (force)
+                        break;
+
+                if (flash->probe(flash) == 1)
+                        break;
+
                 munmap((void *)bios, size);
-
-                flash++;
-        }
-
-        return NULL;
+        }
+
+        if (!flash || !flash->name)
+                return NULL;
+
+        printf("Found chip \"%s %s\" (%d KB) at physical address 0x%lx.\n",
+               flash->vendor, flash->name, flash->total_size, flash_baseaddr);
+        return flash;
 }